-
Notifications
You must be signed in to change notification settings - Fork 2k
chore(deps): use fasyslog for creating syslog payload #22603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
cc @jszwedko |
|
@pront Thanks for your information! It seems @vectordotdev/vector is not a team? Since it's not in bold I'm not sure if the notification is sent. BTW, could you trigger the CI workflow so that I can check if any trivial issues should be fixed? |
|
@pront Fix conflict. Could you retrigger the CI and review this patch? |
|
Aha. I should ping @vectordotdev/vector instead.
|
|
Thank you @tisonkun, there are some new conflicts. I recommend waiting for a day before resolving this because on Mondays we update all dependencies and new conflicts might arise. |
|
@pront Thank you! Resolved now. Would you please trigger the CI and see when to review? Hopefully we don't need to rebase several times later. |
I highly recommend running these before pushing a new commit: vector/.github/PULL_REQUEST_TEMPLATE.md Lines 51 to 53 in 47f5e4f
Also, did you have a chance to test the |
1720078 to
ffe54be
Compare
|
Let me try to redo this one .. long pending and many conflict now 🤣 |
|
Updated. @pront @thomasqueirozb please take a look and hopefully we can avoid further conflict. |
eec393f to
56546c9
Compare
|
Reminder @pront I'd try to send reminder each week or it's likely to be stale later. If you find it too frequent, please let me know :D |
3e971ae to
9358818
Compare
|
Reminder @pront @thomasqueirozb |
|
First conflict :/ |
|
Conflict resolved. cc @pront @thomasqueirozb |
274a5ce to
aebd112
Compare
|
reminder @pront @thomasqueirozb Could you help in triggering the CI workflow? |
|
reminder @pront @thomasqueirozb Could you help in triggering the CI workflow? |
10ae8ab to
ce81c82
Compare
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>

This closes #20955.
Somehow self-promoted and I'm actively maintaining fasyslog. I'd appreciate it if you can give a review and see whether we can go in this way.