Skip to content

Conversation

@tisonkun
Copy link

@tisonkun tisonkun commented Mar 6, 2025

This closes #20955.

Somehow self-promoted and I'm actively maintaining fasyslog. I'd appreciate it if you can give a review and see whether we can go in this way.

@tisonkun tisonkun requested a review from a team as a code owner March 6, 2025 09:46
@bits-bot
Copy link

bits-bot commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Mar 6, 2025
@tisonkun
Copy link
Author

cc @jszwedko

@pront
Copy link
Member

pront commented Mar 10, 2025

cc @jszwedko

Hi @tisonkun, we will taking a look at this PR. Thank you for submitting this. There's a big backlog so it takes a bit longer than usual. Generally, for future PRs (and in case someone from the community reads this) please ping @vectordotdev/vector.

@tisonkun
Copy link
Author

@pront Thanks for your information!

It seems @vectordotdev/vector is not a team? Since it's not in bold I'm not sure if the notification is sent.

BTW, could you trigger the CI workflow so that I can check if any trivial issues should be fixed?

@pront
Copy link
Member

pront commented Mar 11, 2025

It seems @vectordotdev/vector is not a team? Since it's not in bold I'm not sure if the notification is sent.

Interesting, thanks for letting me know:

image

BTW, could you trigger the CI workflow so that I can check if any trivial issues should be fixed?

Done!

@pront pront changed the title refactor: use fasyslog for creating syslog payload chore(deps): use fasyslog for creating syslog payload Apr 2, 2025
@tisonkun
Copy link
Author

tisonkun commented Apr 5, 2025

@pront Fix conflict. Could you retrigger the CI and review this patch?

@tisonkun
Copy link
Author

tisonkun commented Apr 7, 2025

Aha. I should ping @vectordotdev/vector instead.

Fix conflict. Could you retrigger the CI and review this patch?

@pront
Copy link
Member

pront commented Apr 7, 2025

Thank you @tisonkun, there are some new conflicts. I recommend waiting for a day before resolving this because on Mondays we update all dependencies and new conflicts might arise.

@tisonkun
Copy link
Author

tisonkun commented Apr 9, 2025

@pront Thank you! Resolved now.

Would you please trigger the CI and see when to review? Hopefully we don't need to rebase several times later.

@pront
Copy link
Member

pront commented Apr 9, 2025

@pront Thank you! Resolved now.

Would you please trigger the CI and see when to review? Hopefully we don't need to rebase several times later.

I highly recommend running these before pushing a new commit:

- `cargo fmt --all`
- `cargo clippy --workspace --all-targets -- -D warnings`
- `cargo nextest run --workspace` (alternatively, you can run `cargo test --all`)

Also, did you have a chance to test the papertrail sink with your changes?

@thomasqueirozb thomasqueirozb added no-changelog Changes in this PR do not need user-facing explanations in the release changelog meta: awaiting author Pull requests that are awaiting their author. labels Jun 27, 2025
@pront pront force-pushed the master branch 4 times, most recently from 1720078 to ffe54be Compare July 10, 2025 15:43
@thomasqueirozb thomasqueirozb self-assigned this Jul 11, 2025
@tisonkun
Copy link
Author

Let me try to redo this one .. long pending and many conflict now 🤣

@tisonkun tisonkun requested a review from pront November 25, 2025 18:19
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Nov 25, 2025
@tisonkun
Copy link
Author

Updated.

@pront @thomasqueirozb please take a look and hopefully we can avoid further conflict.

@tisonkun tisonkun force-pushed the fasyslog branch 2 times, most recently from eec393f to 56546c9 Compare November 30, 2025 08:23
@tisonkun
Copy link
Author

tisonkun commented Dec 1, 2025

Reminder @pront

I'd try to send reminder each week or it's likely to be stale later. If you find it too frequent, please let me know :D

@tisonkun tisonkun force-pushed the fasyslog branch 2 times, most recently from 3e971ae to 9358818 Compare December 6, 2025 04:47
@tisonkun
Copy link
Author

tisonkun commented Dec 8, 2025

Reminder @pront @thomasqueirozb

@tisonkun
Copy link
Author

First conflict :/

@tisonkun
Copy link
Author

Conflict resolved. cc @pront @thomasqueirozb

@tisonkun tisonkun force-pushed the fasyslog branch 3 times, most recently from 274a5ce to aebd112 Compare December 23, 2025 02:15
@tisonkun
Copy link
Author

reminder @pront @thomasqueirozb

Could you help in triggering the CI workflow?

@tisonkun
Copy link
Author

tisonkun commented Jan 5, 2026

reminder @pront @thomasqueirozb

Could you help in triggering the CI workflow?

@tisonkun tisonkun force-pushed the fasyslog branch 2 times, most recently from 10ae8ab to ce81c82 Compare January 8, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants