Skip to content

Conversation

@thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Jan 9, 2026

Summary

  1. Use setup action whenever possible in jobs triggered by the MMQ. This should speedup jobs by taking advantage of rust caching and vdev caching and will additionally bring some eye candy to the output by enabling color in cargo's output (compilation + errors!).
  2. Always use the correct ref when checking out a branch. This prevents an unlikely "race condition" when a review is left and another commit is pushed later, leading to an incorrect ref being checked out.
  3. Removed PR trigger custom status. All that this did what add a nicer job description to GitHub's output at the expense of yml readability. This is why this PR removes way more lines than it adds.

Example:

  • Before: both Unit - Mac and CI Review Trigger / unit-mac / unit-mac (pull_request_review) would be present when running /ci-run-unit-mac.
  • Now: only CI Review Trigger / unit-mac / unit-mac (pull_request_review) exists

On failure the job is still there regardless, so job visibility is not affected.


I was unable to use the setup action in cross. This is work to be addressed in a future PR.

Runs:

Note that the integration review trigger (.github/workflows/ci-integration-review.yml) seems to not be working properly but that is only being run as a side effect of /ci-run-all and the files changed in this PR do not affect that workflow.

Vector configuration

NA

How did you test this PR?

/ci-run-*

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Jan 9, 2026
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 9, 2026
thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

thomasqueirozb

This comment was marked as outdated.

Copy link
Contributor Author

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-all

Copy link
Contributor Author

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-k8s

@thomasqueirozb thomasqueirozb marked this pull request as ready for review January 12, 2026 20:44
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner January 12, 2026 20:44
Copy link
Contributor Author

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-k8s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants