Skip to content

refactor(vdev): replace manifest generation script with native command - #26546

Merged
pront merged 1 commit into
masterfrom
pront-native-manifest-generation
Oct 6, 2026
Merged

pront merged 1 commit into
masterfrom
pront-native-manifest-generation

Conversation

@pront

@pront pront commented Oct 5, 2026

Copy link
Copy Markdown
Member

Summary

Motivation

Kubernetes manifest generation still lives in a shell script behind vdev build manifests. Move it into vdev so chart-version arguments are parsed directly and the release workflow no longer depends on scripts/generate-manifests.sh.

Changes

  • Replace the script with a native command that pins one Helm chart version, rejects downgrades, and regenerates all three manifest variants, READMEs, and kustomization resource lists.
  • Keep Helm and yq for rendering and YAML cleanup, and finish rendering every variant before replacing existing files.
  • Update the Make target to pass --chart-version directly and bump vdev to 0.3.27 so CI installs the new implementation.

References

Prerequisite to #26469, which removes the remaining script-wrapper macro.

How did you test this PR?

  • Ran the old script and the new command with real Helm and yq against chart 0.58.0: all 22 generated files matched byte-for-byte, and a second native run was unchanged.
  • Passed all 228 vdev tests, including coverage for explicit/default chart versions, downgrade rejection, retries, and preserving existing manifests on Helm or yq failure. Git configuration was isolated for tests that create temporary repositories.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

@github-actions github-actions Bot added the domain: vdev Anything related to the vdev tooling label Oct 5, 2026
@pront
pront marked this pull request as ready for review October 5, 2026 18:05
@pront
pront requested a review from a team as a code owner October 5, 2026 18:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T18:07:37.081576Z 5f85186 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-05T18:10:04.843024Z 5f85186 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 5, 2026

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The native command preserves the former generator’s release wiring and completes all Helm renders before replacing checked-in manifests; no actionable regression was identified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 5f85186 · @DataDog review to ask questions

@pront
pront added this pull request to the merge queue Oct 6, 2026
Merged via the queue into master with commit 600cd8e Oct 6, 2026
106 of 107 checks passed
@pront
pront deleted the pront-native-manifest-generation branch October 6, 2026 16:15
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants