Skip to content

chore(components): Enable pedantic Clippy lints - #26591

Merged
pront merged 2 commits into
masterfrom
pront-pedantic-components
Oct 8, 2026
Merged

pront merged 2 commits into
masterfrom
pront-pedantic-components

Conversation

@pront

@pront pront commented Oct 8, 2026

Copy link
Copy Markdown
Member

Summary

Motivation

Continue the incremental pedantic Clippy rollout in the component-validation infrastructure, keeping this review under 500 changed lines.

Changes

Enable clippy::pedantic for src/components. Apply mechanical fixes to event conversion, resource handling, runner control flow, and synchronization assertions. Keep deferred API documentation, ownership, and numeric-conversion cleanup in narrow allowances linked to #23659.

References

Related: #23659. Split from #26574.

How did you test this PR?

  • Workspace/all-target Clippy passed with component-validation-tests,aws-core enabled.
  • All seven component-validation suites passed, covering HTTP, Splunk HEC, Datadog logs, and Datadog Agent components.
  • Formatting and whitespace checks passed.

The feature set includes aws-core because the HTTP sink has an existing unused_async failure without it, reproduced on unchanged master.

Does this PR include user facing changes?

  • Yes.
  • No.

@pront
pront requested a review from a team as a code owner October 8, 2026 16:52
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T17:22:50.285623Z 874acc5 New commits
🔒 Security Review ✅ Completed 2026-10-08T17:22:21.015248Z 874acc5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The rewritten shutdown matches and panic assertions retain their existing conditions, and metric filtering selects the same events. The completed static reviewer reported no actionable regression.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 40e821c · @DataDog review to ask questions

@pront
pront enabled auto-merge October 8, 2026 17:06
@pront
pront added this pull request to the merge queue Oct 8, 2026
Merged via the queue into master with commit ed27857 Oct 8, 2026
85 checks passed
@pront
pront deleted the pront-pedantic-components branch October 8, 2026 18:11
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants