Skip to content

chore(config): Enable pedantic lints for graph and builders - #26593

Merged
pront merged 2 commits into
masterfrom
pront-pedantic-config-graph
Oct 8, 2026
Merged

pront merged 2 commits into
masterfrom
pront-pedantic-config-graph

Conversation

@pront

@pront pront commented Oct 8, 2026

Copy link
Copy Markdown
Member

Summary

Motivation

Continue the pedantic Clippy rollout through configuration graph construction and builders in an independently mergeable slice under 500 changed lines.

Changes

Enable pedantic checks in the API options, builder, compiler, component, diff, enrichment-table, format, graph, and graph-builder modules. Apply mechanical shared-configuration cleanup, preserving graph ordering, cycle diagnostics, and component identity. Keep deferred cleanup in narrow allowances linked to #23659; parent-module enforcement remains for the final rollout.

References

Related: #23659. Split from #26574.

How did you test this PR?

All 184 selected configuration tests passed, including graph/cycle checks, enrichment-table identity and diff tests, proxy configuration, and configuration unit tests. Workspace/all-target Clippy passed with the relevant component features enabled. One Nextest leak marker on config::api::bind_merge did not recur in an isolated rerun.

Does this PR include user facing changes?

  • Yes.
  • No.

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 8, 2026
@pront
pront requested a review from a team as a code owner October 8, 2026 16:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T17:13:50.660025Z dc53606 New commits
🔒 Security Review ✅ Completed 2026-10-08T17:13:59.761897Z dc53606 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The cycle-traversal branch inversion and glob-expansion rewrites preserve existing control flow and fallback behavior. The lint annotations do not alter runtime behavior.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 43446b3 · @DataDog review to ask questions

@pront
pront enabled auto-merge October 8, 2026 17:07
@pront
pront added this pull request to the merge queue Oct 8, 2026
Merged via the queue into master with commit d02595e Oct 8, 2026
85 checks passed
@pront
pront deleted the pront-pedantic-config-graph branch October 8, 2026 18:30
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants