Repository navigation
chore(config): Enable pedantic lints for loading and schemas - #26594
Merged
Merged
Conversation
pront
added
the
no-changelog
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadoghq-integration[bot]](https://avatars.githubusercontent.com/u/16866914?s=60&v=4){kind=small}
There was a problem hiding this comment.
pront
enabled auto-merge
October 8, 2026 17:07
thomasqueirozb
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Continue the pedantic Clippy rollout in configuration loading, schema handling, and component configuration wrappers while keeping the review below 500 changed lines.
Changes
Enable pedantic checks for the loading, schema, sink, validated-sink, source, and transform configuration modules and the separate secret-backend example. Apply mechanical iterator, default-value, and documentation fixes. Keep existing conversion bounds, error contracts, and ownership behavior behind narrow issue-linked allowances.
References
Related: #23659. Split from #26574.
How did you test this PR?
All 184 selected configuration tests passed, covering environment and secret interpolation, schema coercion, configuration loading, and configuration unit tests. Workspace/all-target Clippy passed with the secret-backend example included. One Nextest leak marker on
glob_expansiondid not recur in an isolated rerun.Does this PR include user facing changes?