Repository navigation
chore(config): Enable pedantic lints for validation and watchers - #26595
Merged
Merged
Conversation
pront
added
the
no-changelog
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadoghq-integration[bot]](https://avatars.githubusercontent.com/u/16866914?s=60&v=4){kind=small}
There was a problem hiding this comment.
pront
enabled auto-merge
October 8, 2026 17:06
thomasqueirozb
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Continue the pedantic Clippy rollout through configuration validation, unit-test support, and file watching in a small, independently mergeable PR.
Changes
Enable pedantic checks in the unit-test, Unix configuration, validation, and watcher modules. Apply mechanical iterator, assertion, and control-flow fixes while retaining existing error contracts, ownership, and numeric conversions through narrow allowances linked to #23659.
References
Related: #23659. Split from #26574.
How did you test this PR?
All 184 selected configuration tests passed on macOS, including configuration unit tests, graph validation, schema handling, and Unix helpers. Workspace/all-target Clippy passed with the normal platform gates. Watcher test code also compiled and passed Clippy with its macOS exclusion temporarily lifted, then restored; watcher runtime validation remains for Linux CI.
Does this PR include user facing changes?