Skip to content

chore(http): Enable pedantic Clippy lints - #26598

Merged
pront merged 2 commits into
masterfrom
pront-pedantic-http
Oct 8, 2026
Merged

pront merged 2 commits into
masterfrom
pront-pedantic-http

Conversation

@pront

@pront pront commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Summary

Motivation

Continue the incremental pedantic Clippy rollout in shared HTTP helpers and both HTTP client implementations.

Changes

Enable clippy::pedantic for the HTTP module, add must_use annotations, and apply mechanical statement and rustdoc fixes. Keep deferred cleanup in narrow allowances with concise reasons linked to #23659. Use the standard OAuth 2.0 name in bearer-token documentation.

References

Related: #23659. Split from #26574.

How did you test this PR?

All 39 HTTP tests passed, including legacy and v1 client coverage for TLS, mutual TLS, authenticated proxies, credential isolation, and proxy bypass. Workspace/all-target Clippy passed with api,aws-core; formatting, documentation generation, and whitespace checks passed.

Does this PR include user facing changes?

  • Yes.
  • No.

@pront
pront requested a review from a team as a code owner October 8, 2026 18:33
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 8, 2026

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The added semicolons preserve unit-returning authentication behavior, while targeted lint allowances retain existing ownership, drop timing, and return types.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit a3f1ba9 · @DataDog review to ask questions

@pront
pront added this pull request to the merge queue Oct 8, 2026
@pront
pront removed this pull request from the merge queue due to a manual request Oct 8, 2026
@pront
pront requested a review from a team as a code owner October 8, 2026 19:33
@github-actions github-actions Bot added the domain: external docs Anything related to Vector's external, public documentation label Oct 8, 2026

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The semicolon edits preserve unit-valued behavior; the remaining changes affect lint annotations and synchronized documentation without changing HTTP transport logic.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit b508d74 · @DataDog review to ask questions

@pront
pront added this pull request to the merge queue Oct 8, 2026
Merged via the queue into master with commit 59a7d04 Oct 8, 2026
111 checks passed
@pront
pront deleted the pront-pedantic-http branch October 8, 2026 20:49
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants