Repository navigation
chore(http): Enable pedantic Clippy lints - #26598
Merged
Merged
Conversation
There was a problem hiding this comment.
thomasqueirozb
approved these changes
Oct 8, 2026
There was a problem hiding this comment.
clreaume
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Continue the incremental pedantic Clippy rollout in shared HTTP helpers and both HTTP client implementations.
Changes
Enable
clippy::pedanticfor the HTTP module, addmust_useannotations, and apply mechanical statement and rustdoc fixes. Keep deferred cleanup in narrow allowances with concise reasons linked to #23659. Use the standard OAuth 2.0 name in bearer-token documentation.References
Related: #23659. Split from #26574.
How did you test this PR?
All 39 HTTP tests passed, including legacy and v1 client coverage for TLS, mutual TLS, authenticated proxies, credential isolation, and proxy bypass. Workspace/all-target Clippy passed with
api,aws-core; formatting, documentation generation, and whitespace checks passed.Does this PR include user facing changes?