Skip to content

chore(internal telemetry): Enable pedantic Clippy lints - #26614

Merged
pront merged 1 commit into
masterfrom
pront-pedantic-internal-telemetry
Oct 9, 2026
Merged

pront merged 1 commit into
masterfrom
pront-pedantic-internal-telemetry

Conversation

@pront

@pront pront commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

Enable pedantic Clippy checks for internal allocation telemetry. Replace manual panic branches with assertions, shorten private metadata field names, and document panic conditions. Retain narrow, issue-linked allowances for hot-path inlining, signed byte accounting, and the paired token API.

References

Related: #23659. Split from #26574.

Vector configuration

The allocation-tracing smoke pipeline used demo_logs -> blackhole and internal_metrics -> console, with --allocation-tracing --allocation-tracing-reporting-interval-ms 100.

How did you test this PR?

  • make fmt and git diff --check passed.
  • Workspace/all-target Clippy passed with sinks-blackhole,sinks-console,sources-demo_logs,sources-internal_metrics,tikv-jemallocator.
  • All 23 selected tracing, internal-metrics, demo-log, and blackhole regression tests passed with the same features.

The allocation-tracing smoke run aborts in AllocationGroupId::from_raw because NonZeroU8::new_unchecked receives zero. The identical failure reproduced on unchanged base 7477209c805bb9cdaa7547d95fd66e650be69423; end-to-end allocation tracing remains unvalidated. The patch was restored byte-for-byte after the comparison.

Does this PR include user facing changes?

  • Yes.
  • No.

@pront
pront requested a review from a team as a code owner October 9, 2026 14:01
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 9, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T14:03:29.780427Z 6174b32 PR opened
🔒 Security Review ✅ Completed 2026-10-09T14:04:29.730094Z 6174b32 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The assertion rewrites preserve existing stack failure conditions, and the metadata renames preserve emitted metric labels. End-to-end allocation tracing remains unvalidated because the PR reports the same abort on the base commit.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 6174b32

@pront
pront added this pull request to the merge queue Oct 9, 2026
Merged via the queue into master with commit bf9eee7 Oct 9, 2026
110 checks passed
@pront
pront deleted the pront-pedantic-internal-telemetry branch October 9, 2026 14:56
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants