Repository navigation
chore(internal telemetry): Enable pedantic Clippy lints - #26614
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The assertion rewrites preserve existing stack failure conditions, and the metadata renames preserve emitted metric labels. End-to-end allocation tracing remains unvalidated because the PR reports the same abort on the base commit.
🤖 Bits Code Review · Commit 6174b32
thomasqueirozb
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable pedantic Clippy checks for internal allocation telemetry. Replace manual panic branches with assertions, shorten private metadata field names, and document panic conditions. Retain narrow, issue-linked allowances for hot-path inlining, signed byte accounting, and the paired token API.
References
Related: #23659. Split from #26574.
Vector configuration
The allocation-tracing smoke pipeline used
demo_logs -> blackholeandinternal_metrics -> console, with--allocation-tracing --allocation-tracing-reporting-interval-ms 100.How did you test this PR?
make fmtandgit diff --checkpassed.sinks-blackhole,sinks-console,sources-demo_logs,sources-internal_metrics,tikv-jemallocator.The allocation-tracing smoke run aborts in
AllocationGroupId::from_rawbecauseNonZeroU8::new_uncheckedreceives zero. The identical failure reproduced on unchanged base7477209c805bb9cdaa7547d95fd66e650be69423; end-to-end allocation tracing remains unvalidated. The patch was restored byte-for-byte after the comparison.Does this PR include user facing changes?