Repository navigation
refactor(codecs): use a validated ASCII character type - #26632
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The shared type preserves single-ASCII-character deserialization and runtime byte conversions while making generated schemas describe string fields and retaining documentation defaults.
🤖 Bits Code Review · Commit f3d6a44
pront
enabled auto-merge
October 9, 2026 20:48
thomasqueirozb
approved these changes
Oct 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASCII configuration fields currently use
u8with per-field Serde adapters. Configs accept a single ASCII character, but schema generation sees an integer. IntroduceAsciiCharso the Rust type, serialization, and generated schema describe the same contract.u8.vdevto0.3.30. Regenerated CUE files and configuration examples are unchanged.Accepted user configurations and runtime output are unchanged. Rust callers constructing these configuration fields now use
AsciiChar; byte-oriented runtime constructors are unchanged.This is an independent prerequisite for the parse-first work, based on
master, with no configuration-loader changes.References
Related: #26475
Vector configuration
Used to compare custom framing and CSV output against the released binary:
How did you test this PR?
make fmtand full-workspacemake check-clippy(all targets and all features).make testfor allvector-core,codecs, andvdevtests, plus Vector HTTP/framing tests: 947 passed, no retries (2,752 outside the scope or ignored).vdev, then ran the generated-docs and component-example checks: no generated-file changes; 248 examples passed, 4 skipped.Ad-hoc comparison fixtures and reports are local-only and are not included in this PR.
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines