Repository navigation
Conversation
When truncating the `message` field of a log event, the `datadog_logs` converts it into a string, chops part of it off, adds a truncation marker string, but then stuffs it back into the event as a `Bytes` value. Since we know it is valid UTF-8 by construction, we can use the `String` type instead. This was previously submitted as part of #26608. While it looks like a bug fix, the extra boundary check is not actually reachable in the current caller and so is purely defensive against future (mis)uses.
bruceg
added
type: tech debt
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadoghq-integration[bot]](https://avatars.githubusercontent.com/u/16866914?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
Storing truncated messages as String preserves their content and encoded size. The completed static review found no compatibility issues in caller handling, agent normalization, or repeated serialization.
🤖 Bits Code Review · Commit f3f7286
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When truncating the
messagefield of a log event, thedatadog_logsconverts it into a string, chops part of it off, adds a truncation marker string, but then stuffs it back into the event as aBytesvalue. Since we know it is valid UTF-8 by construction, we can use theStringtype instead.This was previously submitted as part of #26608. While it looks like a bug fix, the extra boundary check is not actually reachable in the current caller and so is purely defensive against future (mis)uses.
References
Vector configuration
How did you test this PR?
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
@vectordotdev/vectorto reach out to us regarding this PR.git merge origin masterandgit push.