Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inversion fixes and improvements #157

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
40e097a
Change prototype of inversion inversion(circle c1, circle c2, real sg…
ivankokan May 6, 2020
635e25a
Minor edit: inversion(circle c1, circle c2, circle c3) transforms
ivankokan May 6, 2020
0c6f9d0
Add missing optional real argument to signature
ivankokan May 6, 2020
b072889
Abort radicalcenter(circle,circle) for concentric circles (so as in r…
ivankokan May 6, 2020
ce7947f
Remove invalid check within radicalcenter(circle,circle)
ivankokan May 6, 2020
3f8006d
Prettify radicalcenter(circle,circle)
ivankokan May 6, 2020
e7907c3
Revisit and refactor all inverse functions and corresponding operators
ivankokan May 7, 2020
ba13a5b
Align with inversion(circle,circle,real) and avoid redundant inversio…
ivankokan May 8, 2020
7c3fef1
Revisit struct inversion
ivankokan May 8, 2020
aed6e16
Change prototype of lineinversion function and consolidate its usage
ivankokan May 8, 2020
8f0b889
Simplify power of a point operator ^(point,explicit circle)
ivankokan May 8, 2020
7a82751
Edit: inversion radius -> inversion power
ivankokan May 8, 2020
b22478c
Remove unused variable
ivankokan May 9, 2020
b77998e
TODO remarks on radical* functions for degenerate circle(s)
ivankokan May 9, 2020
6b5d52b
Enhance radicalcenter(circle,circle) preserving the current behavior
ivankokan May 9, 2020
bc4a348
Use abs (negative radii are allowed)
ivankokan May 9, 2020
cc58f79
Inversion docs
ivankokan May 10, 2020
6d57c51
Replace regular inversion functions with implicit constructors
ivankokan May 10, 2020
86ccd06
Disallow ambiguous inversions
ivankokan May 10, 2020
f35e0ef
Make inversion an involution
ivankokan May 10, 2020
77237f7
Enhance radicalline(circle,circle) preserving the current behavior
ivankokan May 10, 2020
7f89f0c
Remove redundant comparisons in radicalcenter and radicalline functions
ivankokan May 10, 2020
6e60b80
Pseudocode for radicalcenter(circle,circle,circle)
ivankokan May 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Edit: inversion radius -> inversion power
ivankokan committed May 8, 2020
commit 7a82751af20b0cf54e97fbc301ba4f5ecdd56a92
4 changes: 2 additions & 2 deletions base/geometry.asy
Original file line number Diff line number Diff line change
@@ -6362,8 +6362,8 @@ inversion inversion(point C, real k)
/*<asyxml><function type="inversion[]" signature="inversion(circle,circle,real)"><code></asyxml>*/
inversion[] inversion(circle c1, circle c2, real sgn = 1)
{/*<asyxml></code><documentation>Return the inversions which transform 'c1' to
. 'c2' and positive inversion radius if 'sgn > 0';
. 'c2' and negative inversion radius if 'sgn < 0';
. 'c2' and positive inversion power if 'sgn > 0';
. 'c2' and negative inversion power if 'sgn < 0';
. 'c1' and 'c2' to 'c2' if 'sgn = 0'.</documentation></function></asyxml>*/
if(sgn == 0) {
point O = radicalcenter(c1, c2);