Fix delete wait helpers to poll requested objects#9800
Open
immanuwell wants to merge 2 commits into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
Signed-off-by: immanuwell <pchpr.00@list.ru>
blackpiglet
approved these changes
May 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Fixes three delete-wait helpers that deleted the requested object, then polled the namespace name instead of the object name. Tiny cleanup footgun, but it can make E2E cleanup lie or wait on the wrong thing when
ns != name.Does your change fix a particular issue?
No related issue found.
Repro:
nametonsgo test ./test/util/k8s -run 'TestWaitFor.*DeletePolls' -count=1expected get action for "test-service", got "test-ns"and same deal for Secret/ConfigMapChecked:
go test ./test/util/k8s ./test/util/velero -count=1Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main(not needed; no docs behavior changed).