Skip to content

Fix delete wait helpers to poll requested objects#9800

Open
immanuwell wants to merge 2 commits into
velero-io:mainfrom
immanuwell:fix-delete-wait-poll-name
Open

Fix delete wait helpers to poll requested objects#9800
immanuwell wants to merge 2 commits into
velero-io:mainfrom
immanuwell:fix-delete-wait-poll-name

Conversation

@immanuwell

@immanuwell immanuwell commented May 19, 2026

Copy link
Copy Markdown

Thank you for contributing to Velero!

Please add a summary of your change

Fixes three delete-wait helpers that deleted the requested object, then polled the namespace name instead of the object name. Tiny cleanup footgun, but it can make E2E cleanup lie or wait on the wrong thing when ns != name.

Does your change fix a particular issue?

No related issue found.

Repro:

  • change the helper poll calls back from name to ns
  • run go test ./test/util/k8s -run 'TestWaitFor.*DeletePolls' -count=1
  • tests fail with expected get action for "test-service", got "test-ns" and same deal for Secret/ConfigMap

Checked:

  • go test ./test/util/k8s ./test/util/velero -count=1

Please indicate you've done the following:

Signed-off-by: immanuwell <pchpr.00@list.ru>
Signed-off-by: immanuwell <pchpr.00@list.ru>
@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants