feat(metrics): expose velero_build_info gauge#9934
Open
amarkdotdev wants to merge 3 commits into
Open
Conversation
Register a velero_build_info Prometheus metric labeled with version, git commit, tree state, and Go runtime details at server startup. Fixes velero-io#2128. Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
👷 Deploy request for velero pending review.Visit the deploys page to approve it
|
The build-info metric needs Go's standard `runtime` package, but pkg/cmd/server/server.go already imports `k8s.io/apimachinery/pkg/runtime` under the same name, which broke the build (`runtime` redeclared, `runtime.NewScheme` undefined). Alias the standard library import as `goruntime` and use it for the build-info values, leaving the apimachinery `runtime` untouched. Also add the required changelog entry for this PR. Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ywk253100
previously approved these changes
Jun 29, 2026
Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
Author
|
@ywk253100 Thanks for the review and approval. Pushed If this looks good to you, would you be able to merge when checks pass? Happy to address anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2128.
Registers
velero_build_infoat server startup with labels for version, git commit, tree state, and Go runtime details.Testing
go test ./pkg/metrics/...