Conversation
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
|
||
| fn finish(self) -> Result<(), String> { | ||
| if let Some(frame) = self.pending { | ||
| send_contact_frame(&self.tx, frame)?; |
There was a problem hiding this comment.
I can reproduce record stop failing at --fps 1 --contact-sheet after one page change followed by a pause. The final pending frame hits the 500 ms lag guard even though analysis isn't behind. Could we avoid counting that intentional wait as analyzer lag and add a quiet-page regression test?
| } | ||
|
|
||
| fn consider(&mut self, frame: CapturedVideoFrame) -> Result<(), String> { | ||
| if self.governor.should_send(frame.elapsed) { |
There was a problem hiding this comment.
This changes which UI states a contact sheet can see at low --fps, but the help, recording docs, core skill, and MCP descriptions only explain the pixel-change threshold. Could you update those surfaces to call out the sampling limit and final-frame behavior?
f2e12e7 to
e1be4c1
Compare
e1be4c1 to
27580ef
Compare
27580ef to
00668e9
Compare
|
@ctate i think this is ready to go |
This branch has not been deployed
2 participants
Contact-sheet analysis received every Chrome screencast frame even when the recording requested a lower
--fps, allowing analysis load to exceed the configured capture rate.This applies the recording cadence to contact-sheet candidates and retains the newest suppressed frame at shutdown so the final visual state remains represented. The regression test covers 1 FPS sampling and final-frame preservation.
Validation:
cargo testcargo fmt -- --checkcargo clippy