Skip to content

fix(tabs): avoid throwaway tab before explicit selection - #1987

Open
zyz619963502zyz wants to merge 1 commit into
vercel-labs:mainfrom
zyz619963502zyz:fix/1986-pin-tab-explicit-target
Open

zyz619963502zyz wants to merge 1 commit into
vercel-labs:mainfrom
zyz619963502zyz:fix/1986-pin-tab-explicit-target

Conversation

@zyz619963502zyz

Copy link
Copy Markdown

Summary

  • defer fresh pinned-tab creation when the first auto-launched command explicitly selects an existing tab
  • preserve fresh-tab behavior for other first commands and existing binding recovery
  • add a focused regression for tab_switch with an explicit tabId

Fixes #1986.

Validation

  • cargo test --bin agent-browser explicit_first_tab_selection_does_not_need_a_fresh_pinned_tab -- --nocapture
  • cargo test --bin agent-browser tab_binding -- --nocapture
  • cargo test --bin agent-browser auto_launch -- --nocapture (10 passed, 3 ignored)
  • cargo fmt -- --check

cargo clippy --bin agent-browser -- -D warnings is currently blocked by 19 pre-existing clippy::uninlined_format_args warnings in cli/build.rs; no unrelated baseline files were changed.

@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@zyz619963502zyz is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--pin-tab over --cdp opens a throwaway tab before tab <targetId> binds, and close leaves it behind

1 participant