fix(cdp): reject commands for detached sessions - #1992
Open
zyz619963502zyz wants to merge 1 commit into
Open
zyz619963502zyz wants to merge 1 commit into
zyz619963502zyz wants to merge 1 commit into
Conversation
Contributor
|
@zyz619963502zyz is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Target.detachedFromTargetarrivesCloses #1991
Validation
cargo test detached_session_releases_its_pending_commands -- --nocapturecargo test native::cdp::client::tests(12 passed)cargo test --bin agent-browser(1394 passed, 142 ignored)git diff --checkcargo fmt -- --checkcould not run because the available pinned Rust toolchain does not include the rustfmt component; no component was installed solely for this change.AI assistance
AI assistance was used. I reviewed the implementation and verified the behavior and tests above.