fix(auth): target visible duplicate login fields - #1999
Open
zyz619963502zyz wants to merge 1 commit into
Open
zyz619963502zyz wants to merge 1 commit into
zyz619963502zyz wants to merge 1 commit into
Conversation
Contributor
|
@zyz619963502zyz is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1998
Regression evidence
On the prior implementation, the three Rust 1.88 + Chromium 154/CDP scenarios failed deterministically (0 passed, 3 failed): username, password, and submit each timed out when a hidden matching element preceded the visible control. With this change, the same scenarios pass (3 passed, 0 failed) and assert that hidden inputs remain empty, the hidden submit is not clicked, and the visible form is filled and submitted.
Validation
cargo fmt -- --checkcargo check --bin agent-browsercargo clippy --bin agent-browser(passes with existing warnings)cargo test --bin agent-browser -- --test-threads=1(1393 passed, 0 failed, 145 ignored)The publication preflight completed with no blocking findings. Its only warning was 47 deleted lines from the intentional replacement of the old single-node helper; the committed diff was manually reviewed, contains no deleted files, and the worktree was clean.