fix(openai): allow open_page action type url to be nullish #10646
+23
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lgrammel
reviewed
Dec 2, 2025
| <span className="font-semibold">In URL:</span>{' '} | ||
| <a | ||
| href={output.action.url} | ||
| href={output.action.url ?? undefined} |
Contributor
Author
There was a problem hiding this comment.
hmm might as well remove the span that tries to access the openPage url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
OAI sometimes doesn't render the
urlparam for theopen_pageaction type, leading to validation errors.Summary
Set the parameter to
.nullish()Manual Verification
Checklist
pnpm changesetin the project root)Related Issues
Fixes #9308 and #10669