feat(ai/core): add onChunk callback to streamObject #8282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielamitay
commented
Aug 26, 2025
|
|
||
| if (chunk.type === 'error') { | ||
| onError({ error: wrapGatewayError(chunk.error) }); | ||
| await onError({ error: wrapGatewayError(chunk.error) }); |
There was a problem hiding this comment.
await was missing here from onError, which returns a promise and is also awaited in streamText.
| @param onChunk - Callback that is called for each chunk of the stream. The stream processing will pause until the callback promise is resolved. | ||
| @param onError - Callback that is invoked when an error occurs during streaming. You can use it to log errors. | ||
| @param onFinish - Callback that is called when the LLM response and the final object validation are finished. |
There was a problem hiding this comment.
onError and onFinish codedocs were missing
lgrammel
reviewed
Aug 28, 2025
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lgrammel Please take a look! This PR simply adds onChunk to streamObject to mirror the same behavior for streamText.
Background
Summary
Manual Verification
Tasks
pnpm changesetin the project root)pnpm prettier-fixin the project root)