Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Prodigy Commerce as a commerce provider #1415

Conversation

polykoi
Copy link
Contributor

@polykoi polykoi commented Dec 3, 2024

No description provided.

Copy link

vercel bot commented Dec 3, 2024

@polykoi is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@manovotny
Copy link
Collaborator

  1. There's some console.log statements in the instrumentation.ts. Did you want to leave those in there?
  2. Does Prodigy platform not have a concept of non-product pages? Is that why there's fake pages in lib/prodigy/api/menus.ts?

@polykoi
Copy link
Contributor Author

polykoi commented Jan 14, 2025

  1. It is intended to show those messages in logs. We connect the app to the platform automatically in instrumentation.ts. So those logs can give some clues if something is going wrong with connection process.
  2. No we don't yet have such concept. So we stubbed those pages to conform more to the original template. Users would be able to create and manage non-product pages as part of their app.

@manovotny
Copy link
Collaborator

  1. Sounds good. We'll leave them in.
  2. Would it make sense to leave it this way (markup in string) or would it be better to create standard page.tsx files? All the markup in strings feels icky.

@polykoi
Copy link
Contributor Author

polykoi commented Jan 21, 2025

I didn't like it much too. It was just a quick solution to conform better to existing codebase and simplify syncing maintenance in the future.
I've moved them to separate pages already.

@manovotny manovotny merged commit 6759421 into vercel:main Jan 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants