Fix: Changing Conditions for nextjsProjectExists#188
Open
DhairyaMajmudar wants to merge 2 commits intovercel:masterfrom
Open
Fix: Changing Conditions for nextjsProjectExists#188DhairyaMajmudar wants to merge 2 commits intovercel:masterfrom
nextjsProjectExists#188DhairyaMajmudar wants to merge 2 commits intovercel:masterfrom
Conversation
Author
|
@nicoalbanese pls. have a look : ) |
nicoalbanese
reviewed
Jun 9, 2024
Collaborator
nicoalbanese
left a comment
There was a problem hiding this comment.
Hey! Can you update this to look for any file that has next.config.*
This is because a next config could be .js
https://nextjs.org/docs/pages/api-reference/next-config-js
Author
|
@nicoalbanese I have committed the suggested changes. |
|
also in const path = "next.config.mjs";
const ncExists = existsSync(path);
if (!ncExists) {
console.log("Could not find `next.config.mjs`. Please update it manually.");
}while setting up lucia authentication - it assumes only .config.mjs - for a complete fix addressing this too might be nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the conditions from checking if package.json exists or not to next.config.mjs exists in the
command/inti/index.tsfileCloses #187