Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Update not-found.mdx - outdated example #75331

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

robertotcestari
Copy link

This PR updates the page example to reflect the changes introduced in Next.js 15 regarding access to route parameters.

Specifically, the example will be modified to include the async keyword in the page function definition. This change is necessary because, as of Next.js 15, params is a Promise that needs to be resolved asynchronously.

The update will ensure that the documentation aligns with Next.js v15 code.

This PR updates the page example to reflect the changes introduced in Next.js 15 regarding access to route parameters. 

Specifically, the example will be modified to include the async keyword in the page function definition. This change is necessary because, as of Next.js 15, params is a Promise that needs to be resolved asynchronously. 

The update will ensure that the documentation aligns with Next.js v15 code.
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jan 26, 2025
@ijjk
Copy link
Member

ijjk commented Jan 26, 2025

Allow CI Workflow Run

  • approve CI run for commit: 25438fa

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jan 26, 2025

Allow CI Workflow Run

  • approve CI run for commit: 25438fa

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants