Convert remaining sync (search)params access #75389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Next.js team
eps1lon
force-pushed
the
sebbie/01-28-convert_remaining_sync_search_params_access
branch
from
9e0b40c to
8435a97
Compare
eps1lon
force-pushed
the
sebbie/01-28-convert_remaining_sync_search_params_access
branch
from
8435a97 to
8fc1aab
Compare
leerob
approved these changes
Jan 28, 2025
leerob
deleted the
sebbie/01-28-convert_remaining_sync_search_params_access
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked through all
params.andsearchParams.accesses. Remaining ones are either from Pages Router, not actualparams, OG images (still sync params) or migration docs.headers()andcookies()were all working.