Skip to content

Added @types/jest in installtion commands. #78090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

devchaudhary24k
Copy link
Contributor

For Contributors

Improving Documentation

  • Run pnpm prettier-fix to fix formatting issues before opening the PR.
  • Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines.

Adding or Updating Examples

Fixing a Bug

Adding a Feature

  • Implements an accepted feature request or RFC.
    (Ensure there's an approved discussion: Submit Idea)
  • Link issues or discussions using fixes #number.
  • Add e2e tests where appropriate.
    See: e2e Testing Guide
  • Include updated documentation.
  • Add telemetry (if needed) to determine usage.
  • Ensure errors have helpful links attached.

For Maintainers

  • Provide a minimal, clear description (as if explaining to someone unfamiliar with the context).
  • Share Slack thread summaries when referencing discussions.
  • Link both Linear (Fixes NEXT-xxx) and GitHub issues.
  • Leave review comments where the logic behind changes might not be obvious.

What?

Updated documentation and installation instructions to include @types/jest.

Why?

When setting up Jest in a TypeScript project, omitting @types/jest causes TypeScript to fall back to node:test, leading to incorrect module resolution and runtime errors. Including @types/jest resolves this and ensures a smooth development experience.

How?

Added @types/jest to the recommended install commands wherever applicable, ensuring consistent and error-free setup for users following the docs.

Closes NEXT-
Fixes #

Added @types/jest in installation commands, When directly using the command it later gives an error or imports modules from node:test instead.
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Apr 12, 2025
@ijjk
Copy link
Member

ijjk commented Apr 12, 2025

Allow CI Workflow Run

  • approve CI run for commit: 4a3ec35

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Apr 12, 2025

Allow CI Workflow Run

  • approve CI run for commit: 4a3ec35

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @devchaudhary24k 🙏🏼

@delbaoliveira delbaoliveira enabled auto-merge (squash) April 15, 2025 13:20
@delbaoliveira delbaoliveira merged commit c27264c into vercel:canary Apr 15, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants