Skip to content

add data url css tests #78114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

Conversation

jantimon
Copy link
Contributor

@jantimon jantimon commented Apr 13, 2025

Adding a feature

This PR adds e2e tests for CSS Modules in Data URLs, a feature that was recently merged in PR #78040.

Why?

After the feature was merged, @dlehmhus reported an issue (#78096) where CSS Modules in Data URLs don't work properly in Server Components. These tests will help verify the functionality and serve as regression tests once the issue is fixed.

How?

  • Added comprehensive e2e tests that verify both client and server component behavior with CSS Modules in Data URLs
  • Tests ensure that class names are applied correctly and styles are rendered properly
  • The tests covers base64-encoded CSS module data URLs

These tests don't fix the issue reported in #78096 but provide test coverage for the feature.

Current results:

webpack: Tests: 4 failed, 0 passed, 4 total
turbopack: Tests: 1 failed, 3 passed, 4 total

preview of the e2e test

Relates to #78096

@ijjk ijjk added the tests label Apr 13, 2025
@ijjk
Copy link
Member

ijjk commented Apr 13, 2025

Allow CI Workflow Run

  • approve CI run for commit: 52fd06a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Apr 13, 2025

Allow CI Workflow Run

  • approve CI run for commit: 3993dc7

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants