Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/next-core/src/next_edge/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ pub async fn get_edge_resolve_options_context(
custom_conditions.push(rcstr!("react-server"));
};

if *next_config.enable_cache_components().await? {
custom_conditions.push(rcstr!("next-js"));
};
// Edge runtime is disabled for projects with Cache Components enabled except for Middleware
// but Middleware doesn't have all Next.js APIs so we omit the "next-js" condition for all edge
// entrypoints

let resolve_options_context = ResolveOptionsContext {
enable_node_modules: Some(project_path.root().owned().await?),
Expand Down
5 changes: 4 additions & 1 deletion crates/next-core/src/next_server/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,10 @@ pub async fn get_server_resolve_options_context(
custom_conditions.push(rcstr!("react-server"));
};

if *next_config.enable_cache_components().await? {
if *next_config.enable_cache_components().await?
// Middleware shouldn't use the "next-js" condition because it doesn't have all Next.js APIs available
&& !matches!(ty, ServerContextType::Middleware { .. } | ServerContextType::Instrumentation { .. })
{
custom_conditions.push(rcstr!("next-js"));
};

Expand Down
12 changes: 11 additions & 1 deletion packages/next/src/build/webpack-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,6 @@ export default async function getBaseWebpackConfig(
: distDir

const conditionNames = [
...(config.cacheComponents === true ? ['next-js'] : []),
...(isEdgeServer ? [edgeConditionName] : []),
// inherits Webpack's default conditions
'...',
Expand Down Expand Up @@ -1389,6 +1388,17 @@ export default async function getBaseWebpackConfig(
},
module: {
rules: [
{
issuerLayer: {
not: [WEBPACK_LAYERS.middleware, WEBPACK_LAYERS.instrument],
},
resolve: {
conditionNames: [
config.cacheComponents ? 'next-js' : '',
'...',
].filter(Boolean) as string[],
},
},
// Alias server-only and client-only to proper exports based on bundling layers
{
issuerLayer: {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default function Page() {
return <div>Hello World</div>
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import CJSExportsDefault from 'my-cjs-package/exports'
import ExternalCJSExportsDefault from 'my-external-cjs-package/exports'
import ESMExportsDefault from 'my-esm-package/exports'
import ExternalESMExportsDefault from 'my-external-esm-package/exports'

export function register() {
console.log('==== REGISTER START ====')
console.log('CJSExportsDefault:', CJSExportsDefault)
console.log('ExternalCJSExportsDefault:', ExternalCJSExportsDefault)
console.log('ESMExportsDefault:', ESMExportsDefault)
console.log('ExternalESMExportsDefault:', ExternalESMExportsDefault)
console.log('==== REGISTER END ====')
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"dependencies": {
"my-cjs-package": "file:./sym-linked-packages/my-cjs-package",
"my-esm-package": "file:./sym-linked-packages/my-esm-package",
"my-external-cjs-package": "file:./sym-linked-packages/my-external-cjs-package",
"my-external-esm-package": "file:./sym-linked-packages/my-external-esm-package"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node_modules
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export default function Root({ children }: { children: React.ReactNode }) {
return (
<html>
<body>
<main>{children}</main>
</body>
</html>
)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default function Page() {
return <div>Hello World</div>
}
15 changes: 15 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/middleware/middleware.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import CJSExportsDefault from 'my-cjs-package/exports'
import ExternalCJSExportsDefault from 'my-external-cjs-package/exports'
import ESMExportsDefault from 'my-esm-package/exports'
import ExternalESMExportsDefault from 'my-external-esm-package/exports'

export default async function proxy(req: Request) {
if (!req.url.includes('/_next/')) {
console.log('==== MIDDLEWARE START ====')
console.log('CJSExportsDefault:', CJSExportsDefault)
console.log('ExternalCJSExportsDefault:', ExternalCJSExportsDefault)
console.log('ESMExportsDefault:', ESMExportsDefault)
console.log('ExternalESMExportsDefault:', ExternalESMExportsDefault)
console.log('==== MIDDLEWARE END ====')
}
}
12 changes: 12 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/middleware/next.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/**
* @type {import('next').NextConfig}
*/

const nextConfig = {
serverExternalPackages: [
'my-external-esm-package',
'my-external-cjs-package',
],
}

module.exports = nextConfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"dependencies": {
"my-cjs-package": "file:./sym-linked-packages/my-cjs-package",
"my-esm-package": "file:./sym-linked-packages/my-esm-package",
"my-external-cjs-package": "file:./sym-linked-packages/my-external-cjs-package",
"my-external-esm-package": "file:./sym-linked-packages/my-external-esm-package"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
declare module 'my-cjs-package/exports'
declare module 'my-cjs-package/imports'
declare module 'my-esm-package/exports'
declare module 'my-esm-package/imports'
declare module 'my-external-cjs-package/exports'
declare module 'my-external-cjs-package/imports'
declare module 'my-external-esm-package/exports'
declare module 'my-external-esm-package/imports'
1 change: 1 addition & 0 deletions test/e2e/app-dir/next-condition/fixtures/proxy/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node_modules
9 changes: 9 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/proxy/app/layout.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export default function Root({ children }: { children: React.ReactNode }) {
return (
<html>
<body>
<main>{children}</main>
</body>
</html>
)
}
3 changes: 3 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/proxy/app/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default function Page() {
return <div>Hello World</div>
}
12 changes: 12 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/proxy/next.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/**
* @type {import('next').NextConfig}
*/

const nextConfig = {
serverExternalPackages: [
'my-external-esm-package',
'my-external-cjs-package',
],
}

module.exports = nextConfig
8 changes: 8 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/proxy/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"dependencies": {
"my-cjs-package": "file:./sym-linked-packages/my-cjs-package",
"my-esm-package": "file:./sym-linked-packages/my-esm-package",
"my-external-cjs-package": "file:./sym-linked-packages/my-external-cjs-package",
"my-external-esm-package": "file:./sym-linked-packages/my-external-esm-package"
}
}
8 changes: 8 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/proxy/packages.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
declare module 'my-cjs-package/exports'
declare module 'my-cjs-package/imports'
declare module 'my-esm-package/exports'
declare module 'my-esm-package/imports'
declare module 'my-external-cjs-package/exports'
declare module 'my-external-cjs-package/imports'
declare module 'my-external-esm-package/exports'
declare module 'my-external-esm-package/imports'
15 changes: 15 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/proxy/proxy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import CJSExportsDefault from 'my-cjs-package/exports'
import ExternalCJSExportsDefault from 'my-external-cjs-package/exports'
import ESMExportsDefault from 'my-esm-package/exports'
import ExternalESMExportsDefault from 'my-external-esm-package/exports'

export default async function proxy(req: Request) {
if (!req.url.includes('/_next/')) {
console.log('==== MIDDLEWARE START ====')
console.log('CJSExportsDefault:', CJSExportsDefault)
console.log('ExternalCJSExportsDefault:', ExternalCJSExportsDefault)
console.log('ESMExportsDefault:', ESMExportsDefault)
console.log('ExternalESMExportsDefault:', ExternalESMExportsDefault)
console.log('==== MIDDLEWARE END ====')
}
}
1 change: 1 addition & 0 deletions test/e2e/app-dir/next-condition/fixtures/render/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node_modules
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export default function Root({ children }: { children: React.ReactNode }) {
return (
<html>
<body>
<main>{children}</main>
</body>
</html>
)
}
12 changes: 12 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/render/next.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/**
* @type {import('next').NextConfig}
*/

const nextConfig = {
serverExternalPackages: [
'my-external-esm-package',
'my-external-cjs-package',
],
}

module.exports = nextConfig
8 changes: 8 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/render/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"dependencies": {
"my-cjs-package": "file:./sym-linked-packages/my-cjs-package",
"my-esm-package": "file:./sym-linked-packages/my-esm-package",
"my-external-cjs-package": "file:./sym-linked-packages/my-external-cjs-package",
"my-external-esm-package": "file:./sym-linked-packages/my-external-esm-package"
}
}
8 changes: 8 additions & 0 deletions test/e2e/app-dir/next-condition/fixtures/render/packages.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
declare module 'my-cjs-package/exports'
declare module 'my-cjs-package/imports'
declare module 'my-esm-package/exports'
declare module 'my-esm-package/imports'
declare module 'my-external-cjs-package/exports'
declare module 'my-external-cjs-package/imports'
declare module 'my-external-esm-package/exports'
declare module 'my-external-esm-package/imports'
Loading
Loading