fix: Use a pnpm preinstall script to fix catch-22 in next binary creation#91016
Merged
fix: Use a pnpm preinstall script to fix catch-22 in next binary creation#91016
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This comment was marked as spam.
This comment was marked as spam.
bgw
commented
Mar 9, 2026
Comment on lines
+66
to
+67
| '--lockfile=false', | ||
| '--ignore-workspace', |
Member
Author
There was a problem hiding this comment.
I'm not sure why, and codex wasn't able to figure it out either, but when I was running pnpm i inside of a fresh ubuntu VM, it was trying to modify the pnpm-lock.yaml unless these flags were set due to some sort of workspace isolation issue.
But either way, these flags seem like a small improvement here.
lukesandberg
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We've had a longstanding issue where you'd have to run
pnpm itwice on a fresh checkout becausepnpmwouldn't set up binary symlinks until after the binary exists, but the binary wouldn't exist until afterpnpm buildwas done:https://github.com/vercel/next.js/blob/canary/.github/workflows/build_reusable.yml#L303-L311
This solves that problem using a pnpm preinstall script that creates stub binaries for these files if they don't exist yet (because we haven't run
pnpm build).Test Plan
I tested this both locally and inside of a fresh ubuntu VM.
Running
pnpm nextafterpnpm ibut beforepnpm buildgives a helpful error message: