This repository was archived by the owner on Feb 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appano1
commented
Nov 6, 2024
@@ -12,12 +12,12 @@ module.exports = { | |||
'plugin:import/recommended', | |||
'prettier', | |||
require.resolve('./rules/best-practice'), | |||
require.resolve('./rules/comments'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comments config and a unicorn config to ensure that only pure rules, excluding plugins, are in the rules directory.
appano1
commented
Nov 6, 2024
@@ -1,6 +1,6 @@ | |||
module.exports = { | |||
extends: [ | |||
'plugin:eslint-comments/recommended', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced eslint-comment
to @eslint-community/eslint-comments
cause eslint-comment is not maintained for a while
* Fix no-unused-vars * Add a rule for `*.config.mjs` files. * Install `@types/node` for `process.*`
outslept
reviewed
Nov 14, 2024
Requires ESLint ^8.57.0, or ^9.0.0
Will this be merged anytime soon? |
Hey y'all. This repository has been archived and sunset. The existing configurations will remain public for reference. Thank you 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ESLint ^8.57.0, or ^9.0.0 because of
eslint-plugin-testing-library
.See also: eslint-plugin-testing-library v7 migration guide
Descriptions
Resolves #73
Resolves #108
Resolves #115
Related to #113
The goal of this PR is to minimize breaking changes.
Developers can apply the flat config as follows.
Due to certain characteristics of the flat config, it is not fully identical to the legacy config.
@vercel/style-guide/eslint/browser
and@vercel/style-guide/eslint/node
might not be needed since developers can register them through theglobals
package. Instead, developers can continue to use the existing_base.js
by applying configs.recommended.For
@vercel/style-guide/eslint/jest
, I’ve addedjest-typescript.js
to increase flexibility, as users may need to configure it within the flat config usingoptions.files
.