Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] update warning in ls --update-required for clarity #12864

Merged
merged 3 commits into from
Jan 18, 2025
Merged

[cli] update warning in ls --update-required for clarity #12864

merged 3 commits into from
Jan 18, 2025
+15 −5

Conversation

erikareads
Copy link
Contributor

@erikareads erikareads commented Jan 15, 2025 •
edited
Loading

Closes #12856.

The existing logic assumes that if a discontinueDate has been set for a given version of node, that version of node must be deprecated. It was also easy to mistake the previous code as displaying the warning only after the discontinue date, which it never did.

This PR:

  • Clarifies the language communicating the deprecation to users. It's not that the node version will be deprecated. The node version is already deprecated and is at risk of being discontinued.
  • Adds an identifier to the logic checking for a deprecated node version, making it clear that the date check is looking into the future.
  • Adds a comment clarifying the logic further, and documents the assumption that a discontinueDate means that a node version is deprecated.
  • Adds a further comment noting that if this assumption is invalid, additional logic may be required. Specifically, in the case where we have deprecated a node version, but don't yet know its discontinue date.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 74b1766

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@erikareads erikareads marked this pull request as ready for review January 15, 2025 23:06
trek
trek previously approved these changes Jan 16, 2025
View reviewed changes
@erikareads erikareads added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@erikareads erikareads added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@erikareads erikareads added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@erikareads erikareads dismissed stale reviews from EndangeredMassa and trek via 3589862 January 18, 2025 00:07
@erikareads erikareads force-pushed the erikarowland/clarify-logic-update-required-warning branch from 3589862 to 74b1766 Compare January 18, 2025 00:08
@erikareads erikareads enabled auto-merge January 18, 2025 00:11
@erikareads
Copy link
Contributor Author

I accidentally pushed additional changes to this PR which I used a force push to revert, so this will need to be approved again.

EndangeredMassa
EndangeredMassa approved these changes Jan 18, 2025
View reviewed changes
packages/cli/src/commands/project/list.ts
', '
)}. Please upgrade your projects immediately.`
)} and will be discontinued soon. Please upgrade your projects immediately.`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): mention dates

Ideally we'd have the versions and their dates all listed here.‏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have those dates, I think that's a worthwhile addition.

@erikareads erikareads added this pull request to the merge queue Jan 18, 2025
Merged via the queue into main with commit 4088283 Jan 18, 2025
339 checks passed
@erikareads erikareads deleted the erikarowland/clarify-logic-update-required-warning branch January 18, 2025 18:01
@vercel-release-bot vercel-release-bot mentioned this pull request Jan 18, 2025
Merged
EndangeredMassa pushed a commit that referenced this pull request Jan 28, 2025
@vercel-release-bot @github-actions
Version Packages (#12851)
1e98464 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/[email protected]

### Major Changes

- Initial release
([#12903](#12903))

## @vercel/[email protected]

### Minor Changes

- Add `useWebApi` property to `NodejsLambda` class
([#12873](#12873))

- [build-utils] convert NodeVersion to class and add state getter
([#12883](#12883))
    [ruby] convert RubyVersion to class and add state getter

## [email protected]

### Minor Changes

- [cli] add Node Version to project list output table
([#12895](#12895))

### Patch Changes

- Enable executable bit for `src/vc.js` script
([#12863](#12863))

- Add video integration category to the integration install CLI
([#12870](#12870))

- [cli] update warning in ls --update-required for clarity
([#12864](#12864))

- Added headers for user-supplied rewrites
([#12847](#12847))

- [cli] refactor confirm component to use `client.input.confirm`
interface ([#12846](#12846))

- [build-utils] convert NodeVersion to class and add state getter
([#12883](#12883))
    [ruby] convert RubyVersion to class and add state getter

- Updated dependencies
\[[`56f72ffefb828c3001f7c82259ed0f71db4f629e`](56f72ff),
[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046),
[`b6bb709370d2565121808340d43d0a9d90b53de1`](b6bb709),
[`85a64db8d9b6a6e9f7c6a019d51777930a806584`](85a64db),
[`ac6a62eff7db3b3e2713adc1f5bd6a1331d838ce`](ac6a62e),
[`f65ea2245382dd2449c96f695ed692d419a83868`](f65ea22),
[`7af40c1e9d9916cbe8287359662fc940f1d24fce`](7af40c1),
[`06307180c20ca07b65f7cb5e93b65c977b9ccd70`](0630718),
[`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f),
[`cefda60a603d60cc35e4697c36e751cca411e6bb`](cefda60),
[`003866c4c93e893edb7a5e89b519fc8879b370c0`](003866c)]:
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]

## @vercel/[email protected]

### Minor Changes

- Make vite detection supersede ionic-react
([#12880](#12880))

## @vercel/[email protected]

### Minor Changes

- Add middleware-related helper functions
([#12938](#12938))

## @vercel/[email protected]

### Minor Changes

- Add support for React Router v7
([#12904](#12904))

- Enable `nativeFetch` when `v3_singleFetch` future flag is enabled
([#12918](#12918))

### Patch Changes

- [remix] Create an interface for differences remix vs react-router
([#12925](#12925))

## @vercel/[email protected]

### Minor Changes

- [build-utils] convert NodeVersion to class and add state getter
([#12883](#12883))
    [ruby] convert RubyVersion to class and add state getter

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046),
[`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Bump next from 14.2.10 to 14.2.21
([#12842](#12842))

## @vercel/[email protected]

### Patch Changes

- Fix local file system readdir to not throw on special file system stat
types ([#12915](#12915))

- Updated dependencies
\[[`d645bdd4312730b10bef89ad9e18e111500849fc`](d645bdd)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046),
[`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- ensure defaultLocale rewrite doesn't conflict with user-defined
redirects ([#12916](#12916))

- Added headers for user-supplied rewrites
([#12847](#12847))

## @vercel/[email protected]

### Patch Changes

- Fix requests failing due to the presence of `Transfer-Encoding` header
in edge-function dev server.
([#10701](#10701))

- Split `build()`, `prepareCache()` and `startDevServer()` into separate
files ([#12872](#12872))

- Updated dependencies
\[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046),
[`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Remove support for VERCEL_IPC_FD
([#12908](#12908))

- Add `supportsResponseStreaming` to build output
([#12884](#12884))

## @vercel/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @vercel/[email protected]

## @vercel-internals/[email protected]

### Patch Changes

- Updated dependencies
\[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046),
[`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]:
    -   @vercel/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndangeredMassa EndangeredMassa EndangeredMassa approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

@onsclom onsclom Awaiting requested review from onsclom

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55

@trek trek Awaiting requested review from trek trek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikareads @trek @EndangeredMassa