Skip to content

replace M_PI with std::numbers::pi, bump c++ standart to c++20 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

w0lek
Copy link
Contributor

@w0lek w0lek commented Jun 12, 2025

@w0lek w0lek requested a review from AlexandreSinger June 12, 2025 11:24
Copy link
Collaborator

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@vaughnbetz
Copy link
Collaborator

@AmirhosseinPoolad : just pinging you to double check we've moved over to the ezgl submodule and these commits modify it.

Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, We really need to add a build CI to this repo just to ensure that any changes we make on this side are safe. I will look into that today. I am pretty sure this will be ok.

@AlexandreSinger
Copy link
Contributor

@AmirhosseinPoolad : just pinging you to double check we've moved over to the ezgl submodule and these commits modify it.

Just adding to this, currently Dependabot is set up to track the master branch of EZGL; but just be aware that Dependabot is set up to update VTR once a month. We can decide to make that more frequent if we would like. There are pros and cons to both. If people want a change sooner, they can update the submodule directly (without dependabot) on VTR with no issue.

@vaughnbetz vaughnbetz merged commit 5356019 into verilog-to-routing:master Jun 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants