Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With prometheus-client 0.22.1, names such as
val-aux_openai_gsm8k_reward_mean@1cause the default Prometheus 2.54.1 scrape to fail. Requireprometheus_client>=0.23.1in both dependency files so the client's content negotiation escapes names for legacy scrapers. The new regression test covers text and OpenMetrics responses and checks that normal metrics and label values remain intact.Fixes #184.
Checklist Before Starting
Test
pytest -q tests/monitor/ut: 90 passed, 1 skipped with both prometheus-client 0.23.1 and 0.26.0 on macOS / Python 3.12.train_loss=0.5and the escaped validation metric=0.17.pre-commit run --all-files --show-diff-on-failureandgit diff --checkpassed.Checklist Before Submitting
Codex assisted with the change and validation.