[veomni] feat: bump veomni to v0.1.8#5900
Merged
wuxibin89 merged 1 commit intoverl-project:mainfrom Apr 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Flash Attention in the VeOmni engine by adding a utility to derive sequence length metadata from packed position IDs. It also refactors the parallel configuration to use a tuple for extra parallel sizes and improves the deduplication of basic modules for FSDP. Feedback was provided to ensure that the generated sequence length tensors are moved to the same device as the input position IDs to avoid potential device mismatch errors.
wuxibin89
previously approved these changes
Apr 7, 2026
Collaborator
|
@deerlu Do use need to upgrade veomni in ci? It's still use ByteDance-Seed/VeOmni.git@v0.1.4 |
6805ac7 to
c814128
Compare
Collaborator
Author
done, bumped to v0.1.8 (released today) |
a104340 to
13194fc
Compare
4bad417 to
1f96d92
Compare
- Fix parallel_state init parameter (ep_size -> extra_parallel_sizes) and use set type for basic_modules - Automatically rewrites `flash_attention_2/3/4` to VeOmni SP-aware variants - Add _prepare_veomni_flash_attention_kwargs to precompute cu_seq_lens for packed sequences - Slice position_ids when sp_enabled
1f96d92 to
05c4964
Compare
wuxibin89
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump veomni to v0.1.8
flash_attention_2/3/4to VeOmni SP-aware variantsChecklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.