Apply filter_overlong_prompts in multiturn rollout setting#5965
Open
HwCARI wants to merge 2 commits intoverl-project:mainfrom
Open
Apply filter_overlong_prompts in multiturn rollout setting#5965HwCARI wants to merge 2 commits intoverl-project:mainfrom
HwCARI wants to merge 2 commits intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces prompt truncation logic to the ToolAgentLoop to handle long prompts and prevent crashes. Feedback highlights that self.rollout_config.prompt_length should be used as the truncation limit for consistency with the rollout pipeline. A bug was also identified where an undefined variable self.max_prompt_length would cause an AttributeError. Furthermore, the truncation logic should be extended to cover multi-turn conversation history to ensure the prompt remains within bounds throughout the interaction.
Author
|
@wuxibin89 and @ArronHZG, Could you please review this PR? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2069.
filter_overlong_promptswas silently skipped in the multiturn setting inverl/verl/experimental/agent_loop/tool_agent_loop.py, causing prompts exceedingdata.max_prompt_lengthto pass through unfiltered. This resulted in tensor size mismatches downstream when batching sequences:This PR ensures the overlong prompt filter is applied consistently regardless of whether multiturn tool use is enabled.
Fix
Apply
filter_overlong_promptsinverl/verl/experimental/agent_loop/tool_agent_loop.py.Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.