[veomni] feat: add DeepSeek-V3 to MOE_PARAM_HANDERS#5996
Open
Luosuu wants to merge 1 commit intoverl-project:mainfrom
Open
[veomni] feat: add DeepSeek-V3 to MOE_PARAM_HANDERS#5996Luosuu wants to merge 1 commit intoverl-project:mainfrom
Luosuu wants to merge 1 commit intoverl-project:mainfrom
Conversation
Collaborator
Author
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the deepseek_v3 model by mapping it to the existing qwen3_moe parameter handler. However, feedback indicates that reusing this handler propagates an existing bug where parameter suffixes are redundantly appended, resulting in incorrect mapping keys like '.weight.weight'.
Collaborator
|
It’s verified compatible with veomni, right? |
Collaborator
Author
yes, verified by end-to-end moonlight training |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
deepseek_v3entry toMOE_PARAM_HANDERSmapping inverl/workers/engine/veomni/utils.py, reusing the existing_map_moe_params_qwen3_moehandler since DeepSeek-V3 shares the same MoE parameter mapping logic as Qwen3-MoE.Checklist Before Starting
[{modules}] {type}: {description}Test
This is a configuration-level change (adding a key to a dictionary mapping). The mapping reuses an existing, tested handler function (
_map_moe_params_qwen3_moe). No new logic is introduced.API and Usage Example
No API changes. DeepSeek-V3 MoE models will now be automatically handled by the veomni engine during parameter mapping.
Design & Code Changes
"deepseek_v3": _map_moe_params_qwen3_moeto theMOE_PARAM_HANDERSdict inverl/workers/engine/veomni/utils.py.Checklist Before Submitting
ci-requestchannel.recipesubmodule, please also update the reference. (N/A)