Use gain in 1D FBM noise (and use mul_add)#59
Open
valadaptive wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that 1D FBM noise was previously not using the
gainsetting. This implements that, and also uses fused multiply-add to accumulate the layers of noise if available (currently slower due to a bug, see arduano/simdeez#78).(Side note: The default value for
gainis 2. This seems backwards--most FBM implementations have it set to 0.5 or 1/sqrt(2). See the "Self Similarity" section of this article. Should the default be updated?)