Skip to content

resource: replicate Map/Set changes in GhostMap/GhostSet#2551

Merged
bsdinis merged 2 commits into
mainfrom
bsdinis/zxp
Jun 15, 2026
Merged

resource: replicate Map/Set changes in GhostMap/GhostSet#2551
bsdinis merged 2 commits into
mainfrom
bsdinis/zxp

Conversation

@bsdinis

@bsdinis bsdinis commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@bsdinis bsdinis requested a review from jaylorch June 12, 2026 17:23
@jaylorch

Copy link
Copy Markdown
Collaborator

Looks good! But is it possible to not introduce the new directory level, for greater backward compatibility (and simpler paths)?

@bsdinis

bsdinis commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

Looks good! But is it possible to not introduce the new directory level, for greater backward compatibility (and simpler paths)?

The directory level does not impact backward compatibility or the paths. On the resource/mod.rs there are things like pub use impls::map, for instance, retaining the path vstd::resource::map from before. It does make the difference for contributors about where combinators land and where the user-facing resources live.

bsdinis added 2 commits June 14, 2026 00:34
Currently, the resource algebra directory has three different things:
- The RA/PCM traits
- RA combinators
- Types that hold RAs, meant for off-the-shelf usage

Without breaking clients (imports stay the same), this commit makes this
distinction in the directory structure:
- the traits/theory of RAs stays in the base dir
- the combinators get their own directory
- the implementations get their own directory
@bsdinis bsdinis added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit 7d8e82c Jun 15, 2026
13 checks passed
@bsdinis bsdinis deleted the bsdinis/zxp branch June 15, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants