Support multiple return values in SST#2560
Open
Chris-Hawblitzel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows multiple return values for SST proof/exec functions and
StmX::Callstatements, similar to multiple return values in Boogie. I used this to implement the upcomingverifier::shadow_datafeature. It might also be useful for #1301 and #2436 . For #2436 , for example, we could keep theStmX::Calldestinations aligned with theens_argsextra return-value arguments, rather than having to match a tuple destination inStmX::Callto non-tupleens_argsextra return-value arguments.It remains to be seen what we do with
call_requires/call_ensureswhen there are implicit extra ghost/tracked arguments and return values not present in the original Rust types as seen by the Rust type checker. In some places, we could use existential quantification over the extra arguments and return values. More generally, we might have something likecall_requires_with/call_ensures_withto talk about the extra values. For now, though, I just assert that thecall_requires/call_ensuresaxioms are removed whenever extra arguments and return values are added that aren't part of the original Rust types.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.