Skip to content

note that match/summary features must be functions #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

note that match/summary features must be functions #4166

wants to merge 1 commit into from
+3 −2

Conversation

@andreer
Copy link
Member

@andreer andreer commented Oct 17, 2025

No description provided.

@andreer andreer requested a review from arnej27959 October 17, 2025 13:42
arnej27959
arnej27959 reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@arnej27959 arnej27959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds misleading to me; usually you have mostly simple features like fieldMatch(title) but you can't have compounds, those must be wrapped in functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnej27959 arnej27959 arnej27959 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreer @arnej27959