Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fox: use a strategic merge patch #489

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

okozachenko1203
Copy link
Member

No description provided.

@okozachenko1203 okozachenko1203 changed the title Use a strategic merge patch wip: Use a strategic merge patch Feb 7, 2025
@okozachenko1203 okozachenko1203 marked this pull request as draft February 7, 2025 16:44
@okozachenko1203 okozachenko1203 marked this pull request as ready for review February 13, 2025 13:09
@okozachenko1203 okozachenko1203 changed the title wip: Use a strategic merge patch fox: use a strategic merge patch Feb 13, 2025
@mnaser
Copy link
Member

mnaser commented Feb 18, 2025

@mnaser
Copy link
Member

mnaser commented Feb 18, 2025

>>> from urllib.parse import urlencode
>>> urlencode({
...                     "fieldManager": "atmosphere-operator",
...                     "force": True,
...                 })
'fieldManager=atmosphere-operator&force=True'

I wonder if the issue is uppercase True? that'd be funny.

@mnaser
Copy link
Member

mnaser commented Feb 18, 2025

from urllib.parse import urlencode
urlencode({
... "fieldManager": "atmosphere-operator",
... "force": True,
... })
'fieldManager=atmosphere-operator&force=True'

theory not true :) it does accept True as true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants