Fix startup stall#39521
Merged
Merged
Conversation
remove synchronous winget call from setup
D3athrow-Issues
added a commit
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tfw this PR was GONE it was DISAPPEAREDED from github for two weeks and no one noticed lol
What this does
Fix a startup stall that can prevent the round from starting.
I had a whole thing written up on the last PR but that PR has vanished under mysterious circumstances.
weird huh
Anyway roughly what happens is:
Declare Readyon it and stuff) to the post-start variant (with the join button on it)The fix involves caching dpi on the client (pre-existing) and using the cached dpi rather than using a synchronous
winsetin that critical path. The price of this is that DPI is likely wrong on the New Player Setup windowThis PR might also fix failures to connect where the game just dies instead of connecting. Hard to verify though
Why it's good
people lose their fuckin minds when the game is supposed to start but doesn't
How it was tested
Changelog
🆑