RSDK-13906: Fix agent redownloading itself on fresh install on Windows - #270
Merged
Evan Dorsky (EvanDorsky) merged 21 commits intoAug 4, 2026
Merged
Conversation
Evan Dorsky (EvanDorsky)
added
the
dev-release
Cheuk (cheukt)
approved these changes
Jul 14, 2026
Cheuk (cheukt)
left a comment
Cheuk (cheukt)
left a comment
Member
There was a problem hiding this comment.
lgtm if manually testing looks good
Evan Dorsky (EvanDorsky)
marked this pull request as ready for review
July 15, 2026 14:18
|
Hey Evan Dorsky (@EvanDorsky) — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
Evan Dorsky (EvanDorsky)
changed the title
|
Hey Evan Dorsky (@EvanDorsky) — this PR has been approved and CI has been green for 8+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey Evan Dorsky (@EvanDorsky) — this PR has been approved and CI has been green for 13+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…s#277) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…robotics#280) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds some logic within agent to check whether the currently-running agent binary is the one that we want to be running, in cases where the version cache doesn't reflect the current-running binary (like after an install that doesn't update the version cache).
It looks like the reason we were redownloading the binary was because the Windows installer didn't update the version cache - but Claude persuaded me that it made more sense to have agent "heal" this case itself, since there are also certain paths in the unix install that can put agent in the same state.
Also added a test for this logic. Now that this branch is up, I think I can do an end-to-end test by building the dev release binary and pinning a machine to that, then installing on Windows with a custom MSI.