PR comments

viamrobotics · Jan 27, 2025 · 705b59d · 705b59d
1 parent a51e4e0
commit 705b59d
Showing 1 changed file with 2 additions and 15 deletions.
diff --git a/proto/viam/app/v1/app.proto b/proto/viam/app/v1/app.proto
@@ -190,9 +190,6 @@ service AppService {
   // Gets a single fragment
   rpc GetFragment(GetFragmentRequest) returns (GetFragmentResponse);
 
-  // Gets usage for a fragment across versions
-  rpc GetFragmentUsage(GetFragmentUsageRequest) returns (GetFragmentUsageResponse);
-
   // Creates a fragment
   rpc CreateFragment(CreateFragmentRequest) returns (CreateFragmentResponse);
 
@@ -836,8 +833,6 @@ message FragmentRevision {
 message FragmentTag {
   string tag = 1;
   string revision = 2;
-  google.protobuf.Timestamp created_at = 3;
-  google.protobuf.Timestamp updated_at = 4;
 }
 
 enum FragmentVisibility {
@@ -867,7 +862,7 @@ message FragmentUsage {
   int32 organizations = 2;
   int32 machines = 3;
   int32 machines_in_current_org = 4;
-  string version = 5;
+  optional string version = 5; // revision or tag
 }
 
 message ResolvedFragment {
@@ -890,7 +885,7 @@ message ListFragmentsResponse {
 message GetFragmentRequest {
   string id = 1;
   string current_organization_id = 2;
-  optional string version = 3;
+  optional string version = 3; // revision or tag
 }
 
 message GetFragmentResponse {
@@ -900,14 +895,6 @@ message GetFragmentResponse {
   repeated FragmentTag tags = 4;
 }
 
-message GetFragmentUsageRequest {
-  string fragment_id = 1;
-}
-
-message GetFragmentUsageResponse {
-  repeated FragmentUsage version_usages = 1;
-}
-
 message CreateFragmentRequest {
   string name = 1;
   google.protobuf.Struct config = 2;