Skip to content

DOCS-3295: Add profiles #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DOCS-3295: Add profiles #4318

wants to merge 3 commits into from

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented May 19, 2025 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented May 19, 2025 •
edited
Loading

✅ Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 62bc60a
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/687501bf5eecfa0008022f55
😎 Deploy Preview https://deploy-preview-4318--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 40 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@npentrel npentrel marked this pull request as draft May 19, 2025 13:57
@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label May 19, 2025
@viambot
Copy link
Member

viambot commented May 19, 2025

It looks like the following files may have been renamed. Please ensure you set all needed aliases:
rename docs/data-ai/reference/triggers-configuration.md => static/include/webhooks.md (50%)

@npentrel npentrel marked this pull request as ready for review July 11, 2025 11:15
nathan-contino
nathan-contino requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and a couple of suggestions; the only (potential) blocker is the lack of a section on the new profiles family of commands.

docs/dev/tools/cli.md
You can also authenticate your CLI session with profiles which allow you to switch between using different privileges.

```sh {class="command-line" data-prompt="$" data-output="2-10"}
viam profiles add --profile-name=default --key-id=<api-key-id> --key=<api-key>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to see a new section about the profiles command -- there should be update, add, list, and remove subcommands. Are we deliberately omitting that section?

FYI, when I try to run list with no profiles specified, I see the following output:

Error: Unexpected end of JSON input

It might be worth checking to see if this happens on your machine as well -- if so, we should probably let engineering know.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that bug just got fixed so should be gone next week!

npentrel and others added 2 commits July 14, 2025 15:08
@npentrel npentrel requested a review from nathan-contino July 14, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-contino nathan-contino Awaiting requested review from nathan-contino

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @viambot @nathan-contino