RSDK-9707: Make API a private dependency of SDK #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
njooma and
stuqdog
and removed request for
a team
acmorrow
reviewed
Jan 14, 2025
| @@ -15,7 +15,7 @@ add_library(viam-cpp-sdk::viamsdk ALIAS viamsdk) | |||
| # `BASE_DIRS` below, because otherwise we will pull in the static | |||
| # versions of the proto files even if we are generating dynamically. | |||
| target_include_directories(viamsdk | |||
| PUBLIC | |||
| PRIVATE | |||
acmorrow
approved these changes
Jan 14, 2025
| @@ -39,10 +39,17 @@ target_sources(viamsdk_test | |||
| test_utils.cpp | |||
| ) | |||
|
|
|||
| target_include_directories(viamsdk_test | |||
There was a problem hiding this comment.
Is it a goal to eventually make the tests not know about viamapi either, or, considered harmless?
There was a problem hiding this comment.
I think doable but considered harmless!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.