Fix links in diff graph by tapishr · Pull Request #205 · vibinex/vibi-dpu

tapishr · 2025-04-17T06:14:09Z

Please check the action items covered in the PR -

Build is running
Eventing is functional and tested
Unit or integration tests added and running
Manual QA

Summary by CodeRabbit

Chores
- Added debug logging to improve visibility into message processing and path handling. These logs provide additional diagnostic information without affecting application behavior.

coderabbitai · 2025-04-17T06:14:16Z

Walkthrough

Debug log statements were added in three source files to improve runtime diagnostics. In the graph utility module, a log records the computed relative path in a path conversion function. In the pubsub listener module, multiple logs capture the extracted message type, raw data bytes for a specific message type, and the constructed attribute map during message processing. In the core trigger module, a log outputs the result of parsing a trigger message. No changes were made to logic, error handling, or public interfaces.

Changes

File(s)	Change Summary
vibi-dpu/src/graph/utils.rs	Added a debug log statement to output the relative path in the `absolute_to_relative_path` function.
vibi-dpu/src/pubsub/listener.rs	Added debug log statements to log the extracted `msgtype`, raw data bytes for `"manual_trigger"`, and the constructed attribute map during message processing.
vibi-dpu/src/core/trigger.rs	Added a debug log statement to output the parsing result in the `process_trigger` function.

Poem

A sprinkle of logs in the code today,
To help us see what comes our way.
Paths, triggers, messages revealed,
Debugging secrets once concealed.
With every hop and every trace,
The rabbit finds each hiding place!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3bc44a and 8e7be42.

📒 Files selected for processing (2)

vibi-dpu/src/core/trigger.rs (1 hunks)
vibi-dpu/src/pubsub/listener.rs (4 hunks)

✅ Files skipped from review due to trivial changes (2)

vibi-dpu/src/core/trigger.rs
vibi-dpu/src/pubsub/listener.rs

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: dpu (vibi-prod)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

vibi-dpu/src/graph/utils.rs (1)

190-198: Consider removing redundant debug log
You log rel_path_res at line 190 and then immediately log rel_path at line 197. Since these messages convey very similar information, you may want to consolidate or remove one to reduce noise in the debug output.

vibi-dpu/src/pubsub/listener.rs (1)

34-34: Enhance logging consistency
The new debug for msgtype is useful, but adopting a structured key-value format (e.g., log::debug!("process_message msgtype"; "type" => %msgtype);) can make filtering and parsing logs easier. Also verify that msgtype alone cannot expose PII or sensitive metadata.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59fd2d0 and a3bc44a.

📒 Files selected for processing (2)

vibi-dpu/src/graph/utils.rs (1 hunks)
vibi-dpu/src/pubsub/listener.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: dpu (vibi-prod)

coderabbitai · 2025-04-17T06:16:13Z

+		log::debug!("[listen_messages] attrmap = {:?}", &attrmap);
 		let message_hash = digest(&*message.message.data);


🛠️ Refactor suggestion

Sanitize logged message attributes
Dumping the entire attrmap risks leaking sensitive attributes (tokens, personal data, etc.). Consider filtering or redacting sensitive keys before logging, or restrict this detailed debug output to non-production environments.

sonarqubecloud · 2025-04-17T07:04:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

add debug msgs

a3bc44a

coderabbitai Bot reviewed Apr 17, 2025

View reviewed changes

add debug logs for manual trigger

8e7be42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix links in diff graph#205

Fix links in diff graph#205
tapishr wants to merge 2 commits into
mainfrom
tr/fix/file_link

tapishr commented Apr 17, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 17, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Apr 17, 2025

Uh oh!

sonarqubecloud Bot commented Apr 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		log::debug!("[listen_messages] attrmap = {:?}", &attrmap);
		let message_hash = digest(&*message.message.data);

Conversation

tapishr commented Apr 17, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Apr 17, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tapishr commented Apr 17, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)