Adds getRecordCount() to the Victims Database Interface. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no way for a client to determine the number of records in the victims database. One thing that this is useful for is determining if a scan is worthwhile or if an update should be issued. The only other workaround is to check the lastUpdate vs time(0) but this is not derived from the actual database state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any callers to be able to check if the database is empty and been initialized correctly.
Presently the only way to do this is by relying on the lastUpdate and compare date returned to time(0) which is disconnected from the actual database state.
Whilst this approach works I'm not sure it is 'the best' way to achieve this. For example you could do something similar to this that doesn't require the client to call this method explicitly. Maybe you could throw an exception if the client attempts to perform a scan when the database has no entries ?