Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homework results #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

homework results #4

wants to merge 2 commits into from

Conversation

ptrBodnar
Copy link

@ptrBodnar ptrBodnar commented Jul 9, 2020

Hope I am doing everything correctly)

@vikua
Copy link
Owner

vikua commented Aug 1, 2020

Well done.

Things I liked:

  • Doing custom type inference. This is very tricky part which nevertheless is super important in AML space. We never have types provided for us in real world.
  • Using ordinal encoder for tree based models! Good job on solving unknown category problem
  • Playing with different model types (linear, trees, gb)

Minor comments:

  • Target for this dataset is loss. It is fine that you picked different column in dataset as target, but I'm not sure why doing so.
  • Maybe different optimization approach would lead to better scores (e.g. Random search, Bayesian)
  • [off topic] You don't need to commit files from lectures.

@ptrBodnar
Copy link
Author

Thank you!

About comments:

  1. Honestly i just missed what was the target from task setting therefore picked yhe one that looked probable.
  2. Yes, I haven't done that due ti the lack of time mostly.
  3. Oh, sure haven't thought about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants