perf: optimize picker performance with event queue and preview debouncing #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 81.77% 82.14% +0.37%
==========================================
Files 26 27 +1
Lines 1761 1798 +37
Branches 176 185 +9
==========================================
+ Hits 1440 1477 +37
Misses 318 318
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lambdalisue
force-pushed
the
performance-imp
branch
from
0f90033 to
8c92a7d
Compare
lambdalisue
changed the title
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Cache byte length calculations for prefix and suffix strings in InputComponent to avoid repeated getByteLength() calls during rendering. This improves performance when the same prefix/suffix values are used repeatedly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace forEach with for loop for better performance and add early return when event queue is empty. Also add comprehensive tests for event handling including edge cases for large event counts and events dispatched during consumption. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Modify picker event handlers to restart only the affected processor instead of restarting from the matcher. When sorter changes, restart sort processor with matcher output. When renderer changes, restart render processor with sorter output. This avoids redundant matching operations. Also implement copy-on-write for sort processor to prevent modifying the input array, ensuring pipeline integrity. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
lambdalisue
force-pushed
the
performance-imp
branch
from
dd0de9f to
6704a15
Compare
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
lambdalisue
force-pushed
the
performance-imp
branch
from
6704a15 to
3bb15e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Performance Impact
These changes significantly improve the responsiveness of the fall picker, especially when:
🤖 Generated with Claude Code