Skip to content

Conversation

lambdalisue
Copy link
Collaborator

@lambdalisue lambdalisue commented Jul 6, 2025

Summary

  • Removed brotli compression from session saving/loading to improve performance
  • Made savePickerSession and loadPickerSession synchronous functions
  • Updated documentation to reflect the change

Background

Session compression was causing performance issues when saving picker sessions. By removing the compression overhead, sessions are now saved and loaded much faster.

Changes

  • Removed brotli compression dependency from session.ts
  • Removed PickerSessionCompressed type and related compression/decompression functions
  • Updated savePickerSession to be synchronous (no longer returns a Promise)
  • Updated loadPickerSession to be synchronous (no longer returns a Promise)
  • Updated all files that use these functions to handle synchronous behavior
  • Updated documentation in doc/fall.txt to remove mention of compression

Test plan

  • All existing tests pass
  • No lint errors
  • Type checking passes
  • Session saving and loading works correctly without compression

🤖 Generated with Claude Code

Copy link

codecov bot commented Jul 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (2c66097) to head (f55583b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   82.09%   81.77%   -0.33%     
==========================================
  Files          26       26              
  Lines        1793     1761      -32     
  Branches      178      176       -2     
==========================================
- Hits         1472     1440      -32     
  Misses        318      318              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lambdalisue lambdalisue force-pushed the fix-session-performance branch from 179c579 to ebfc896 Compare July 6, 2025 10:43
@lambdalisue lambdalisue marked this pull request as draft July 6, 2025 11:11
Session saving/loading was using brotli compression which added
unnecessary overhead. Sessions are now stored uncompressed in memory
for better performance.

Changes:
- Remove brotli compression dependency
- Make savePickerSession and loadPickerSession synchronous
- Update all dependent files to handle uncompressed sessions
- Update documentation to reflect the change

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@lambdalisue lambdalisue force-pushed the fix-session-performance branch from ebfc896 to f55583b Compare July 6, 2025 11:22
@lambdalisue lambdalisue changed the title fix: make session saving asynchronous to improve picker close performance fix: remove session compression to improve performance Jul 6, 2025
@lambdalisue lambdalisue marked this pull request as ready for review July 6, 2025 11:23
@lambdalisue lambdalisue merged commit e435174 into main Jul 6, 2025
6 checks passed
@lambdalisue lambdalisue deleted the fix-session-performance branch July 6, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant